Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Important Notice about the Marlowe Transition #193

Merged
merged 1 commit into from
May 14, 2024

Conversation

nhenin
Copy link
Collaborator

@nhenin nhenin commented May 14, 2024

Summary by CodeRabbit

  • Documentation
    • Removed outdated support badge link.
    • Added an important notice about the repository's move to a new GitHub organization for community-driven management.

Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

The recent update to the Readme.md file involves the removal of a support badge link from the HTML section and the addition of an important notice about the repository's relocation to a new GitHub organization. This change aims to enhance clarity and inform users about the new community-driven management approach.

Changes

File Change Summary
Readme.md Removed a support badge link from the HTML section.
Readme.md Added a notice about the repository's move to a new organization.

🐇✨ In the meadow of code so bright,
A badge took flight into the night.
A notice now shines, clear and grand,
Guiding us to a new, united land.
With community at the helm, we steer,
To horizons fresh, we all draw near. 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nhenin nhenin merged commit 32b736a into main May 14, 2024
2 of 3 checks passed
@nhenin nhenin deleted the nhenin/transition-notice branch May 14, 2024 16:21
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Out of diff range and nitpick comments (5)
Readme.md (5)

Line range hint 29-29: Consider a shorter alternative to avoid wordiness.

- In order to interact with Marlowe contracts, the **TS-SDK** needs a Runtime instance.
+ To interact with Marlowe contracts, the **TS-SDK** needs a Runtime instance.

Line range hint 38-38: Unpaired symbol: ‘]’ seems to be missing.

- To get a running instance of the Runtime, it is recommended to check out the instructions on the [Marlowe Starter Kit](https://github.com/input-output-hk/marlowe-starter-kit)
+ To get a running instance of the Runtime, it is recommended to check out the instructions on the [Marlowe Starter Kit](https://github.com/input-output-hk/marlowe-starter-kit).

Line range hint 55-57: The official spelling of this programming framework is “Node.js”.

- ### Lucid and NodeJS
+ ### Lucid and Node.js
- This allows you to use the SDK in a NodeJS environment.
+ This allows you to use the SDK in a Node.js environment.

Line range hint 63-63: To make your writing flow more naturally, try moving ‘also’ between the auxiliary and the verb.

- Prototypes have been also built on top of this sdk:
+ Prototypes have also been built on top of this sdk:

Line range hint 9-14: Images should have alternate text (alt text) for accessibility.

- <a href="" target="blank_">
-   <img src="./doc/image/logo.svg" alt="Logo" height="75">
- </a>
- <a href=""><img src="https://img.shields.io/badge/stability-beta-33bbff.svg" alt="Beta"></a>
- <a href="./LICENSE"><img src="https://img.shields.io/badge/License-Apache_2.0-blue.svg"></a>
- <a href="https://discord.com/invite/cmveaxuzBn"><img src="https://img.shields.io/discord/826816523368005654?label=Chat%20on%20Discord"></a>
+ <a href="" target="blank_">
+   <img src="./doc/image/logo.svg" alt="Marlowe SDK Logo" height="75">
+ </a>
+ <a href=""><img src="https://img.shields.io/badge/stability-beta-33bbff.svg" alt="Beta Stability"></a>
+ <a href="./LICENSE"><img src="https://img.shields.io/badge/License-Apache_2.0-blue.svg" alt="Apache 2.0 License"></a>
+ <a href="https://discord.com/invite/cmveaxuzBn"><img src="https://img.shields.io/discord/826816523368005654?label=Chat%20on%20Discord" alt="Chat on Discord"></a>
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a809587 and a2a30b7.
Files selected for processing (1)
  • Readme.md (1 hunks)
Additional Context Used
LanguageTool (5)
Readme.md (5)

Near line 29: Consider a shorter alternative to avoid wordiness.
Context: ....io/marlowe-ts-sdk/) page. ## Runtime In order to interact with Marlowe contracts, the **...


Near line 38: Unpaired symbol: ‘]’ seems to be missing
Context: ...ed to check out the instructions on the [Marlowe Starter Kit](https://github.com/...


Near line 55: The official spelling of this programming framework is “Node.js”.
Context: ... | ? | ### Lucid and NodeJS The SDK also provides a wrapper ar...


Near line 57: The official spelling of this programming framework is “Node.js”.
Context: ...ry. This allows you to use the SDK in a NodeJS environment. ## Examples & Contract Us...


Near line 63: To make your writing flow more naturally, try moving ‘also’ between the auxiliary and the verb.
Context: ...ferent packages of the SDK. Prototypes have been also built on top of this sdk: - Payouts ...

Comment on lines +17 to +20
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period at the end of the sentence for consistency.

- > See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
+ > See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.

Comment on lines +17 to +23
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces and reduce multiple consecutive blank lines for cleaner formatting.

- > [!IMPORTANT] 
- > This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br> 
- > This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
- > See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
- 
- 
- 
+ > [!IMPORTANT]
+ > This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
+ > This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh).<br>
+ > See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
+

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh). <br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.
> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This will allow us to ensure community representation and stewardship. Future developments and support for Marlowe are transitioning to a community-driven model initially led by [Simon Thompson](https://github.com/simonjohnthompson), [Nicolas Henin](https://github.com/nhenin) and [Tomasz Rybarczyk](https://github.com/paluh).<br>
> See [here](https://github.com/marlowe-lang/.github/blob/main/profile/transition.md) for details.

</div>

> [!IMPORTANT]
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using bare URLs. Consider embedding the URL in a descriptive text.

- > This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
+ > This Marlowe repository will soon be moved to [the new Marlowe organization on GitHub](https://github.com/marlowe-lang). The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
> This Marlowe repository will soon be moved to https://github.com/marlowe-lang. The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>
> This Marlowe repository will soon be moved to [the new Marlowe organization on GitHub](https://github.com/marlowe-lang). The new repositories will be administered by an independent vehicle, a not-for-profit organization currently being set up by the transition team.<br>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant