-
Notifications
You must be signed in to change notification settings - Fork 7
Improve stub server #102
Improve stub server #102
Conversation
c2c678d
to
09ed767
Compare
I really don't know what's going on with the hashes... I'm inserting the exact same metadata from testnet into the SMASH mock DB manually and the hash will not match the one from testnet... the wallet will always barf out:
Edit: figured it out |
09ed767
to
de57d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the inlined code and will approve and merge.
Also, I think you will need to rebase. I would have fixed the branch but I see you forked it. In the future, please keep the branches in this repo. If you don't have permission, just ping me in Slack. |
Yes, I don't think I have permissions |
Added you, you now have write access. |
de57d39
to
5009f6e
Compare
Applied comments and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better.
bors r+ |
Btw, unrelated to this PR, but I noticed during compilation
|
Build succeeded: |
Related: #97