Kornev/add c flags and fix FW issues #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 20:23
Let the compiler to protect you from shooting yourself in the foot
Fix different issues spotted by compiler
evgenykor
force-pushed
the
kornev/add_c_flags
branch
from
5497e1f to
decef5a
Compare
marcos-diaz
reviewed
Nov 16, 2024
| // If the buffer is full, ignore the latest messages. | ||
| if (webusb_ptr_in + len >= WEBUSB_BUFFER_SIZE-64-1) { | ||
| return; | ||
| } | ||
| // Add message to the buffer. | ||
| strncpy(webusb_buffer + webusb_ptr_in, msg, len); | ||
| memcpy((char*)(webusb_buffer + webusb_ptr_in), msg, len); | ||
| webusb_buffer[webusb_ptr_in + len] = '\0'; |
There was a problem hiding this comment.
I will have to try if this creates problems, the WebUSB buffer is not string based, but takes fixed size chunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.