Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and adjust @angular/pwa so ctrl app works offline and as a local PWA #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gerotakke
Copy link

This adds Angulars service worker/PWA implementation so that the Ctrl app works offline.
I have used the white Inputlabs logo for the icons because that was the one that was available in the highest resolution. I think it should be the green one though.
I needed to bump some versions in package.json to install it.
As I wrote in Discord:

The only downside I could find is that new versions are fetched at the mercy of their ngsw-worker — it worked very reliably for me but I couldn't quite pinpoint the exact time when it happens. So for “regular users”, a reload or clearing the cache doesn't reliably fetch the newest version, but a reload after a couple of seconds on the site should usually work. A real version number in the lower left corner would really come in handy here 😉
What reliably works is an incognito window though, and for local dev serving, the service worker is disabled anyway.

@marcos-diaz
Copy link
Contributor

Thanks for the PR.

Here there is a 2000px PNG logo, I cannot export easily in SVG because the animation thingies.
logo_green_black

I will review the PR properly in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants