Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readfile: support Gamma SLC in complex32 format #1216

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jun 11, 2024

Description of proposed changes

  • utils.readfile: support Gamma slc in complex32 format

    • add scomplex to complex32 data type conversion
    • read_binary_file(): support .rslc/rmli file extension
    • read_complex_int16(): refactor to use cpx_band in str for a more flexible output data; revise the output from 2 matrices into 1 matrix
    • read_binary(): support complex32 while calling read_complex_int16(), since it's not supported in numpy.
  • utils.readfile.auto_no_data_value(): add geometrical offset files from alos2App with num of band = 1

  • view.viewer.plot(): set pixels with no data value to np.nan, instead of call np.ma.masked_where(), which seems over-complicated (compared with setting to nan) and I could not recall the reason anymore.

  • cli/prep_isce.py: set -f default from str to list, to be consistent with the non-default var type.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Pass local test
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ utils.readfile: support Gamma slc in complex32 format
   - add scomplex to complex32 data type conversion
   - read_binary_file(): support .rslc/rmli file extension
   - read_complex_int16(): refactor to use cpx_band in str for a more flexible output data; revise the output from 2 matrices into 1 matrix
   - read_binary(): support complex32 while calling read_complex_int16(), since it's not supported in numpy.

+ utils.readfile.auto_no_data_value(): add geometrical offset files from alos2App with num of band = 1

+ view.viewer.plot(): set pixels with no data value to np.nan, instead of call np.ma.masked_where(), which seems over-complicated (compared with setting to nan) and I could not recall the reason anymore.

+ cli/prep_isce.py: set -f default from str to list, to be consistent with the non-default var type.
attempt to free up the disk space, and to fix the circle CI testing failure.
to show the full error msg, by reverting part of insarlab#472.
@yunjunz
Copy link
Member Author

yunjunz commented Jun 12, 2024

Local testing passed without issue. The failed circle CI test shows that GDAL can not be imported, but it's installed during the installation process. Nevertheless, the circle CI error is not related with the PR, and probably due to some issue on circle CI itself.

@yunjunz yunjunz merged commit 00d6f10 into insarlab:main Jun 12, 2024
6 of 7 checks passed
@yunjunz yunjunz deleted the gamma_cpx32 branch June 12, 2024 09:03
yunjunz added a commit to yunjunz/MintPy that referenced this pull request Aug 1, 2024
yunjunz added a commit to yunjunz/MintPy that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant