Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for numpy 2.0 #1225

Merged
merged 4 commits into from
Jul 16, 2024
Merged

bugfix for numpy 2.0 #1225

merged 4 commits into from
Jul 16, 2024

Conversation

Liuqi2002519
Copy link
Contributor

@Liuqi2002519 Liuqi2002519 commented Jul 16, 2024

Description of proposed changes

  • remove all occurrences of np.string_ with np.bytes_, as the former has been removed in numpy 2.0

  • utils.time_func.get_design_matrix4polynomial_func(): swtich from np.math.factorial() to math.factorial(), as the former is removed from numpy 2.0

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Pass local test
  • Make sure that your code follows our style. Use the other functions/files as a basis.

Copy link

welcome bot commented Jul 16, 2024

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz self-requested a review July 16, 2024 13:44
@yunjunz yunjunz changed the title Bug fix for numpy 2.0 bugfix for numpy 2.0 Jul 16, 2024
@yunjunz yunjunz merged commit 9844947 into insarlab:main Jul 16, 2024
6 of 8 checks passed
Copy link

welcome bot commented Jul 16, 2024

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants