Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

816 add precision argument to ext01@main #824

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

816 add precision argument to ext01@main #824

wants to merge 19 commits into from
+129 −39

Conversation

BFalquet
Copy link
Contributor

close #816

  • add precision argument to ext01
  • add test
  • update NEWS

thank you for the review

@BFalquet BFalquet requested a review from shajoezhu February 27, 2025 09:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Unit Tests Summary

  1 files   58 suites   3m 15s ⏱️
294 tests 293 ✅ 1 💤 0 ❌
689 runs  680 ✅ 9 💤 0 ❌

Results for commit cf6bf7d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
aet04 💔 $4.19$ $+6.97$ $+8$ $-2$ $0$ $0$
chevron_tlg-methods 💔 $7.78$ $+1.73$ $+5$ $-14$ $0$ $0$
coxt01 💔 $0.53$ $+1.11$ $+6$ $-1$ $0$ $0$
coxt02 💔 $0.66$ $+1.50$ $+6$ $-1$ $0$ $0$
lbt14 💔 $7.00$ $+1.24$ $+4$ $-10$ $0$ $0$
rspt01 💔 $3.73$ $+3.70$ $+12$ $-7$ $0$ $0$
ttet01 💔 $3.06$ $+2.42$ $+6$ $-4$ $0$ $0$
utils 💔 $0.17$ $+2.16$ $+61$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
aet04 💔 $0.80$ $+1.24$ aet04_can_handle_NA_values
aet04 💔 $3.38$ $+5.72$ aet04_can_handle_some_NA_values
coxt01 💔 $0.50$ $+1.12$ coxt01_can_handle_some_NA_values
coxt02 💔 $0.63$ $+1.51$ coxt02_can_handle_some_NA_values
ext01 👶 $+0.52$ ext01_precision_argument_works_as_expected
utils 👶 $+0.01$ convert_to_month_warning_messages_as_expected
utils 👶 $+0.02$ convert_to_month_work_as_expected
utils 👶 $+0.01$ do_call_errors_as_expected
utils 👶 $+0.01$ do_call_work_as_expected
utils 👶 $+0.00$ droplevels.character_works_as_expected
utils 👶 $+0.03$ execute_with_args_works_as_expected
utils 👶 $+0.01$ expand_list_works
utils 👶 $+0.01$ format_date_works_as_expected_for_Date
utils 👶 $+0.01$ format_date_works_as_expected_for_POSIXct
utils 👶 $+0.01$ get_section_div_works
utils 👶 $+0.88$ gg_list_is_deprecated
utils 👶 $+0.02$ gg_theme_chevron_works_as_expected
utils 👶 $+0.90$ grob_list_is_deprecated
utils 👶 $+0.01$ lvls.character_works_as_expected
utils 👶 $+0.01$ lvls.default_works_as_expected
utils 👶 $+0.01$ lvls.factor_works_as_expected
utils 👶 $+0.01$ modify_character_works
utils 👶 $+0.01$ modify_default_args_works_as_expected
utils 👶 $+0.01$ quote_str_works_as_expected
utils 👶 $+0.02$ set_section_div_works

Results for commit 1f79835

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      163       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       85       2  97.65%   57, 213
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt01.R                       59       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       2  96.97%   129-130
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       97      12  87.63%   86, 90-94, 126-130, 133, 178
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 29       0  100.00%
R/rmpt01.R                      59       1  98.31%   132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     121       3  97.52%   203-206
R/unwrap.R                      36       0  100.00%
R/utils.R                      178      13  92.70%   277-280, 284-287, 314, 318, 330, 332, 344
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3522      92  97.39%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +27      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                      +25      +1  -0.69%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt01.R                      +59       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1      -3  +4.43%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       +1     +11  -11.33%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +29       0  +100.00%
R/rmpt01.R                      -6     -10  +15.23%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +4       0  +0.08%
R/unwrap.R                     +36       0  +100.00%
R/utils.R                      +94     +13  -7.30%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +451     +17  -0.17%

Results for commit: cf6bf7d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu Awaiting requested review from shajoezhu

@clarkliming clarkliming Awaiting requested review from clarkliming

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chevron sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add precision argument to ext01
2 participants
@BFalquet @shajoezhu