Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

458 cran crash #459

Merged
merged 4 commits into from
Dec 5, 2024
Merged

458 cran crash #459

merged 4 commits into from
Dec 5, 2024

Conversation

gravesti
Copy link
Collaborator

@gravesti gravesti commented Dec 3, 2024 •
edited
Loading

I think this should solve the issue.

  • Creates the model file with a hash containing the R version and versions of a number of important packages
  • Deletes any other cached rbmi MMRM models which don't match the hash to prevent a build up

@gravesti gravesti linked an issue Dec 3, 2024 that may be closed by this pull request
crashes in CRAN tests #458
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@gravesti
Copy link
Collaborator Author

gravesti commented Dec 3, 2024

I have read the CLA Document and I hereby sign the CLA

@gravesti
Copy link
Collaborator Author

gravesti commented Dec 3, 2024

recheck

@gravesti gravesti requested a review from gowerc December 3, 2024 13:08
gowerc
gowerc approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@gowerc gowerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gravesti gravesti merged commit 78a74f2 into main Dec 5, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gowerc gowerc gowerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crashes in CRAN tests
2 participants
@gravesti @gowerc