31 update and add new vignette #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shajoezhu
requested review from
edelarua,
Melkiades and
ayogasekaram
as code owners
Unit Tests Summary 1 files 2 suites 10s ⏱️ Results for commit 9a27c5f. ♻️ This comment has been updated with latest results. |
Co-authored-by: b_falquet <[email protected]> Signed-off-by: Joe Zhu <[email protected]>
Co-authored-by: b_falquet <[email protected]> Signed-off-by: Joe Zhu <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
|
✅ All contributors have signed the CLA |
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
Signed-off-by: Emily de la Rua <[email protected]>
…into 31_update_and_add_new_vignette
edelarua
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Hi @shajoezhu,
I reviewed your changes and all of the documentation throughout the package and made some small improvements (mostly just clarifying some of the wording), and I think it all looks great! This PR should be good to go now.
Thanks!!
shajoezhu
commented
Jan 14, 2025
Signed-off-by: Joe Zhu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.