Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to arbitrary lines UI #211

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Add tooltip to arbitrary lines UI #211

merged 4 commits into from
Dec 14, 2022

Conversation

asbates
Copy link
Contributor

@asbates asbates commented Dec 5, 2022

  • Adds an explanatory tooltip for 'Value' input in arbitrary lines UI.
  • To do this, adds new function with_tooltip

Fixes #111

According to the Bootstrap docs (BS5, BS3), tooltips are opt-in and must be initialized individually. However, I am seeing tooltips display even without explicitly initializing them. Anyone know why? Can we rely on this always being the case or should we run JS to initialize?

…explanatory tooltip for value input of arbitrary lines ui
@asbates
Copy link
Contributor Author

asbates commented Dec 5, 2022

So I didn't realize until submitting this PR that teal has a class. I can update to use this class tomorrow.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  --------------
R/tm_g_gh_boxplot.R                        336     336  0.00%    218-611
R/tm_g_gh_correlationplot.R                540     540  0.00%    285-926
R/tm_g_gh_density_distribution_plot.R      268     268  0.00%    163-474
R/tm_g_gh_lineplot.R                       549     549  0.00%    186-827
R/tm_g_gh_scatterplot.R                    234     234  0.00%    169-453
R/tm_g_gh_spaghettiplot.R                  276     276  0.00%    228-564
R/toggleable_slider.R                      145     145  0.00%    82-243
R/utils-arbitrary_lines.r                   85      70  17.65%   19-78, 107-136
R/utils-data_constraints.r                 166     166  0.00%    2-233
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    26-38
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                    7       7  0.00%    12-19
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2687    2672  0.56%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  -------
R/utils-arbitrary_lines.r      +19      +4  +17.65%
TOTAL                          +19      +4  +0.56%

Results for commit: b416519

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Unit Tests Summary

1 files  1 suites   0s ⏱️
1 tests 1 ✔️ 0 💤 0
3 runs  3 ✔️ 0 💤 0

Results for commit 6c7a5f3.

@chlebowa
Copy link
Contributor

chlebowa commented Dec 6, 2022

I like the work 👍 Some modules in teal.osprey put this information in labels, like so.

@asbates
Copy link
Contributor Author

asbates commented Dec 6, 2022

I like the work 👍 Some modules in teal.osprey put this information in labels, like so.

Nice! I hadn't seen that. This makes me feel even more like we ought to consider a standard way to do this. Maybe a function like here or even just documenting somewhere to use CSS classes provided by teal.

@nikolas-burkoff nikolas-burkoff self-assigned this Dec 8, 2022
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup 👍

@nikolas-burkoff
Copy link
Contributor

@asbates can this be merged?

@asbates asbates merged commit de5d8dc into main Dec 14, 2022
@asbates asbates deleted the 111-add-tooltip@main branch December 14, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tooltip to arbitrary lines UI
3 participants