Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1071 prerelease cleanup@main #1072

Merged
merged 15 commits into from
Feb 20, 2024
Merged

1071 prerelease cleanup@main #1072

merged 15 commits into from
Feb 20, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Feb 19, 2024

Close #1071

This PR was meant to update README and DESCRIPTION file up to standards we had for other teal packages before the release. Some of the DESCRIPTION changes are CRAN requirements.

Summary

  • Review and update README.md
    • add CRAN badges to README
    • add Getting Help section to README
    • change installation guidelines to use CRAN
    • cleanup usage section
  • Package Title is not duplicated in Package Description in DESCRIPTION file
  • Make sure all teal.* mentions are lower-cased and quoted
  • Make sure each link to our documentation hosted with pkgdown on github pages do not have /main/ in the address
    • it should have has /latest-tag/ instead
    • so we always expose the documentation of the latest release and not what's currently on main branch but not yet released
  • All package names in Title and Description fields of DESCRIPTION file are quoted with ' (not backtick)

@m7pr m7pr added the core label Feb 19, 2024
@m7pr m7pr marked this pull request as ready for review February 19, 2024 11:18
@m7pr
Copy link
Contributor Author

m7pr commented Feb 19, 2024

Hey @donyunardi @shajoezhu a small PR for the things I reckon we missed during pre-release activities. I know the package was submitted to CRAN but I think it's gonna be rejected because teal was mentioned in DESCRIPTION file with improper backticks.
Feel free to extend USAGE section with a minimal example of how to quickly run this package with maybe one module.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit ab7d230.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu marked this pull request as draft February 19, 2024 11:52
@shajoezhu
Copy link
Contributor

hi @m7pr , appreciate the fix! I am blocking this merge for now. as i am awaiting for cran submission feedback, if it doesnt succeed in the first round, we will include all changes here, otherwise, let's include this pr, and fix everything in the next round. i submitted the package last night, hopefully we hear something back soon. thanks again!

@m7pr
Copy link
Contributor Author

m7pr commented Feb 19, 2024

I've seen you submitted the package.

I was involved in release and submissions of teal.logger and teal.reporter and this was a NO-GO for CRAN maintainers

All package names in Title and Description fields of DESCRIPTION file are quoted with ' (not backtick)

so I think this submission will be rejected, and that's why I come up with this PR.
If you get a rejection you can use this PR to address any other feedback that they have.

@shajoezhu
Copy link
Contributor

Thanks @m7pr ! Yes, definitely! I don't think it will go through in the first trial, I am hoping to get some feedback and address them according, appreciate that you sharing the latest experience, I think we will include all these changes anyway, let's give it another day

@shajoezhu shajoezhu marked this pull request as ready for review February 20, 2024 22:52
@shajoezhu shajoezhu enabled auto-merge (squash) February 20, 2024 22:59
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks a lot @m7pr

@shajoezhu shajoezhu merged commit 3d87f22 into main Feb 20, 2024
48 checks passed
@shajoezhu shajoezhu deleted the 1071_prerelease_cleanup@main branch February 20, 2024 22:59
@m7pr
Copy link
Contributor Author

m7pr commented Feb 21, 2024

no worries, happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Did we miss package related activities during pre-release?
3 participants