-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1071 prerelease cleanup@main #1072
Conversation
Merge branch 'main' of https://github.com/insightsengineering/teal.modules.clinical # Conflicts: # R/dynamic_assertions.R # man/dyn_assertion.Rd
Hey @donyunardi @shajoezhu a small PR for the things I reckon we missed during pre-release activities. I know the package was submitted to CRAN but I think it's gonna be rejected because |
Unit Tests Summary 1 files 33 suites 2s ⏱️ Results for commit ab7d230. ♻️ This comment has been updated with latest results. |
hi @m7pr , appreciate the fix! I am blocking this merge for now. as i am awaiting for cran submission feedback, if it doesnt succeed in the first round, we will include all changes here, otherwise, let's include this pr, and fix everything in the next round. i submitted the package last night, hopefully we hear something back soon. thanks again! |
I've seen you submitted the package. I was involved in release and submissions of
so I think this submission will be rejected, and that's why I come up with this PR. |
Thanks @m7pr ! Yes, definitely! I don't think it will go through in the first trial, I am hoping to get some feedback and address them according, appreciate that you sharing the latest experience, I think we will include all these changes anyway, let's give it another day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks a lot @m7pr
no worries, happy to help |
Close #1071
This PR was meant to update README and DESCRIPTION file up to standards we had for other teal packages before the release. Some of the DESCRIPTION changes are CRAN requirements.
Summary
Title
is not duplicated in PackageDescription
in DESCRIPTION fileteal.*
mentions are lower-cased and quoted/main/
in the address/latest-tag/
insteadTitle
andDescription
fields of DESCRIPTION file are quoted with'
(not backtick)