Soft deprecate & use datasets_selected argument when possible

insightsengineering · Jan 10, 2025 · 883d667 · 883d667
1 parent 341e039
commit 883d667
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/R/tm_data_table.R b/R/tm_data_table.R
@@ -113,7 +113,7 @@ tm_data_table <- function(label = "Data Table",
     })
   }
   if (!is.null(datasets_selected)) {
-    lifecycle::deprecate_stop(
+    lifecycle::deprecate_soft(
       when = "0.4.0",
       what = "tm_data_table(datasets_selected = 'is deprecated, use `datanames`')"
     )

diff --git a/R/tm_front_page.R b/R/tm_front_page.R
@@ -81,7 +81,7 @@ tm_front_page <- function(label = "Front page",
   checkmate::assert_multi_class(additional_tags, classes = c("shiny.tag.list", "html"))
   checkmate::assert_character(footnotes, min.len = 0, any.missing = FALSE)
   if (!is.null(show_metadata)) {
-    lifecycle::deprecate_stop(
+    lifecycle::deprecate_soft(
       when = "0.4.0",
       what = "tm_front_page(show_metadata = 'is deprecated, use `datanames`')"
     )

diff --git a/R/tm_variable_browser.R b/R/tm_variable_browser.R
@@ -81,8 +81,8 @@
 #' @export
 #'
 tm_variable_browser <- function(label = "Variable Browser",
-                                datasets_selected = NULL,
-                                datanames = NULL,
+                                datasets_selected = "all",
+                                datanames = datasets_selected,
                                 parent_dataname = "ADSL",
                                 pre_output = NULL,
                                 post_output = NULL,
@@ -103,7 +103,7 @@ tm_variable_browser <- function(label = "Variable Browser",
   # Start of assertions
   checkmate::assert_string(label)
   if (!is.null(datasets_selected)) {
-    lifecycle::deprecate_stop(
+    lifecycle::deprecate_soft(
       when = "0.4.0",
       what = "tm_variable_browser(datasets_selected = 'is deprecated, use `datanames`')"
     )

diff --git a/man/tm_front_page.Rd b/man/tm_front_page.Rd
diff --git a/man/tm_variable_browser.Rd b/man/tm_variable_browser.Rd