Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vignette: shiny as a module #1467

Merged
merged 13 commits into from
Feb 4, 2025
Merged

Vignette: shiny as a module #1467

merged 13 commits into from
Feb 4, 2025

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Jan 29, 2025

closes #1450

@gogonzo gogonzo added the core label Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Unit Tests Summary

  1 files   28 suites   10m 39s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit e4e490f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $130.41$ $+2.15$ $0$ $0$ $0$ $0$

Results for commit 4455c05

♻️ This comment has been updated with latest results.

@gogonzo gogonzo mentioned this pull request Jan 29, 2025
Merged
llrs-roche
llrs-roche reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good some minor comments about wording. Feel free to ignore

vignettes/getting-started-with-teal.Rmd Outdated Show resolved Hide resolved
R/module_session_info.R Outdated Show resolved Hide resolved
vignettes/teal-as-a-module.Rmd Outdated Show resolved Hide resolved
vignettes/teal-as-a-module.Rmd Outdated Show resolved Hide resolved
vignettes/teal-as-a-module.Rmd Show resolved Hide resolved
@llrs-roche llrs-roche self-assigned this Feb 4, 2025
llrs-roche
llrs-roche approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just two minor comments.

I was also thinking if the vignette could use shinylive to show the apps or not. It is not in Suggests and I'm not sure if is added in other packages' vignettes. But currently is short and to the point.

vignettes/getting-started-with-teal.Rmd Show resolved Hide resolved
vignettes/teal-as-a-module.Rmd Show resolved Hide resolved
@gogonzo gogonzo enabled auto-merge (squash) February 4, 2025 09:09
@gogonzo gogonzo merged commit ee10bb4 into main Feb 4, 2025
29 checks passed
@gogonzo gogonzo deleted the 1450_vignette branch February 4, 2025 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@donyunardi donyunardi donyunardi left review comments

@llrs-roche llrs-roche llrs-roche approved these changes

Assignees

@llrs-roche llrs-roche

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Vignette for teal as a module
4 participants
@gogonzo @donyunardi @llrs-roche @vedhav