Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review decorator vignette #1470

Merged
merged 18 commits into from
Feb 4, 2025
Merged

Review decorator vignette #1470

merged 18 commits into from
Feb 4, 2025

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi marked this pull request as ready for review January 30, 2025 05:36
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Tests Summary

  1 files   28 suites   10m 48s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit e6762dc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $139.49$ $-7.48$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💚 $54.03$ $-1.51$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💚 $43.71$ $-1.14$ $0$ $0$ $0$ $0$
shinytest2-init 💚 $30.27$ $-1.55$ $0$ $0$ $0$ $0$
shinytest2-landing_popup 💚 $48.76$ $-1.10$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💚 $39.32$ $-1.62$ $0$ $0$ $0$ $0$
shinytest2-modules 💚 $42.06$ $-1.39$ $0$ $0$ $0$ $0$

Results for commit 563d1c8

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Jan 30, 2025
@donyunardi donyunardi requested a review from gogonzo January 31, 2025 06:04
vignettes/decorate-module-output.Rmd Outdated Show resolved Hide resolved
vignettes/decorate-module-output.Rmd Outdated Show resolved Hide resolved
vignettes/decorate-module-output.Rmd Outdated Show resolved Hide resolved
vignettes/decorate-module-output.Rmd Outdated Show resolved Hide resolved
vignettes/decorate-module-output.Rmd Outdated Show resolved Hide resolved
gogonzo and others added 2 commits January 31, 2025 09:45
donyunardi and others added 2 commits February 3, 2025 14:51
Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Dony Unardi <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: Dony Unardi <[email protected]>
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging this one in order to proceed to #1476

@gogonzo gogonzo enabled auto-merge (squash) February 4, 2025 09:00
@gogonzo gogonzo merged commit 2298516 into main Feb 4, 2025
28 checks passed
@gogonzo gogonzo deleted the 99_review_vignette_decorator@main branch February 4, 2025 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants