-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce tolerence #83
reduce tolerence #83
Conversation
Code Coverage Summary
Diff against main
Results for commit: 769ab24 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary7 tests 6 ✅ 0s ⏱️ Results for commit 769ab24. ♻️ This comment has been updated with latest results. |
This looks good - it would be great if we can test it. However it fails on some unrelated step before. I actually observed identical error in other repos as well so it might be some bug in the central testing infrastructure. |
The underlaying issue had been fixed. I re-run the workflow and it continues to fail. Please have a look: https://github.com/insightsengineering/tern.rbmi/actions/runs/11885263587 |
Looking into the test itself. It looks to me that these are string (!) comparison - not numerical values. Hence the tolerance parameter does not change anything. Can we convert into numeric comparison with tolerance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw the test results and it's passing. LGTM 👍
Pull Request
Fixes #82
currently still failing for macos, see https://github.com/insightsengineering/tern.rbmi/actions/runs/11885263587 for more details