CHEF-7406 kubectl exec client #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Signed-off-by: Sathish Babu <sbabu@progress.com>
Vasu1105
reviewed
Jan 9, 2024
spec/spec_helper.rb
Outdated
| require "train/k8s/container" | ||
| require "byebug" |
|
Please merge #11 before this to auto bump versions |
sathish-progress
commented
Jan 9, 2024
| res = shell.run_command | ||
| Train::Extras::CommandResult.new(res.stdout, res.stderr, res.exit_status) | ||
| rescue Errno::ENOENT => _e | ||
| Train::Extras::CommandResult.new("", "", 1) |
There was a problem hiding this comment.
add error details
…F-7406-kubectl-exec-client
Signed-off-by: Sathish Babu <sbabu@progress.com>
|
I am merging this @sathish-progress but we need to add the code comments #10 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support exec commands to be executed on the container
Description
This transport allows to execute commands on the container in the kubectl cluster. In order to execute the commands on the container we introduce a
kubectl_exec_clientwhich takes pod, container_name and namespace as arguments to initialize a connection object, on which commands can be executed. Every command executed resultsstdoutandstderrmethods to know the results of the command.Related Issue
Types of changes
Checklist: