-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEF-7406 specs for transporter #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
…F-7406-specs-for-transporter
…in-k8s-container into CHEF-7406-specs-for-transporter
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
Signed-off-by: Sathish Babu <[email protected]>
…F-7406-specs-for-transporter
def connect; end | ||
# TODO: implement this | ||
def connect | ||
raise NotImplementedError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specs are expected to fail at this stage
Signed-off-by: Sathish Babu <[email protected]>
merging this as it is expected to fail at this stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds coverage for specs
Description
This PR fixes existing specs as well test more cases. Raises NotImplementedError for connections.
Related Issue
Types of changes
Checklist: