Elastic search v0 #37
Conversation
DonHaul
force-pushed
the
elastic-search-v0
branch
from
ee9d6a4 to
566ce2e
Compare
DonHaul
force-pushed
the
elastic-search-v0
branch
7 times, most recently
from
828d794 to
98012b7
Compare
|
@DonHaul you were right, this is wrong https://github.com/inspirehep/backoffice/blob/main/.github/workflows/integration-tests.yml#L24 we should use the opensearch image from dockerhub, could you please make a separate PR with the correct image? |
Sure. |
good question, for the following reasons:
hence I will recommend to align these images, we can use in both cases the one from the registry: |
|
Okay done, regarding the local.yml environment variables I don't know exactly what they should be so I modify them to be a mix between what they were before and the ones found in github actions |
| @@ -21,7 +21,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| services: | |||
| opensearch: | |||
| image: registry.cern.ch/cern-sis/inspire/opensearch | |||
There was a problem hiding this comment.
@DonHaul we have to make a separate PR for this change and merge it first.
There was a problem hiding this comment.
Separate PR here:
https://github.com/inspirehep/backoffice/pull/39/files
backoffice/utils/pagination.py
Outdated
|
|
||
| class StandardResultsSetPagination(PageNumberPagination): | ||
| page_size = 10 | ||
| page_size_query_param = "page_size" |
backoffice/utils/pagination.py
Outdated
|
|
||
| class OSStandardResultsSetPagination(QueryFriendlyPageNumberPagination): | ||
| page_size = 10 | ||
| page_size_query_param = "page_size" |
DonHaul
force-pushed
the
elastic-search-v0
branch
from
58ec905 to
16088eb
Compare
|
@DonHaul could you please rebase? |
DonHaul
force-pushed
the
elastic-search-v0
branch
from
16088eb to
2606ffd
Compare
|
@DonHaul a test is failing |
No description provided.