Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

restart-workflows-fix #84

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

DonHaul
Copy link
Contributor

@DonHaul DonHaul commented Aug 14, 2024

Issue was, the DELETE request needed a data field for it to work as we set the "Content-Type": "application/json"

Fix:
Since the requests library automatically adds "Content-Type": "application/json" if the data field is present. I removed this field from the default headers

@DonHaul DonHaul changed the title airflow utils: adapted headers restart-workflows-fix Aug 15, 2024
@drjova
Copy link
Contributor

drjova commented Aug 15, 2024

Thanks, AFAIU from the docs it's only when we are using json instead of data. With a quick look, it think that's the case for us.

Copy link
Contributor

@drjova drjova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DonHaul since it's on backoffice could you please change the commit message to:

backoffice: workflows modification of the headers

and the we can merge

@DonHaul DonHaul force-pushed the restart-workflow-fix branch from ba0c75f to dc5a047 Compare August 15, 2024 08:42
@DonHaul
Copy link
Contributor Author

DonHaul commented Aug 15, 2024

Thanks, AFAIU from the docs it's only when we are using json instead of data. With a quick look, it think that's the case for us.

You're right, I got the terms mixed up

@DonHaul DonHaul merged commit ed845d4 into inspirehep:main Aug 15, 2024
3 checks passed
@DonHaul DonHaul linked an issue Aug 15, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart workflow action don't work
3 participants