This repository was archived by the owner on Nov 21, 2024. It is now read-only.
airflow: add dag integrity test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonHaul
force-pushed
the
dag-integrity-test
branch
from
dc407aa to
82165e8
Compare
DonHaul
force-pushed
the
dag-integrity-test
branch
from
4359261 to
9bac7f6
Compare
drjova
reviewed
Aug 19, 2024
docker-compose.yaml
Outdated
| @@ -48,10 +48,10 @@ x-airflow-common: &airflow-common | |||
| # In order to add custom dependencies or upgrade provider packages you can use your extended image. | |||
| # Comment the image line, place your Dockerfile in the directory where you placed the docker-compose.yaml | |||
| # and uncomment the "build" line below, Then run `docker-compose build` to build the images. | |||
| image: apache/airflow:2.8.3-python3.11 | |||
| # image: apache/airflow:2.9.3-python3.11 | |||
There was a problem hiding this comment.
we can remove it completely
DonHaul
force-pushed
the
dag-integrity-test
branch
from
9bac7f6 to
4c651f2
Compare
drjova
reviewed
Aug 19, 2024
| @@ -99,7 +99,7 @@ def set_author_update_workflow_status_to_completed(**context): | |||
| collection=AUTHORS, | |||
| ) | |||
|
|
|||
| @task.branch(provide_context=True) | |||
| @task.branch() | |||
There was a problem hiding this comment.
It is now implicitly detected
https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html#airflow-operators-python-pythonoperator
Even in the code, they pop it.
https://airflow.apache.org/docs/apache-airflow/2.9.3/_modules/airflow/operators/python.html#:~:text=if%20kwargs.get(%22provide_context%22)%3A
There was a problem hiding this comment.
Thanks for the detailed explaination.
drjova
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.