This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
delete workflow #87
Merged
delete workflow #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonHaul
force-pushed
the
delete-dag
branch
4 times, most recently
from
ebe4a67 to
2313da1
Compare
drjova
reviewed
Aug 20, 2024
Comment on lines
+186
to
+192
| method: DELETE | ||
| uri: http://airflow-webserver:8080/api/v1/dags/author_create_initialization_dag/dagRuns/00000000-0000-0000-0000-000000000001 | ||
| response: | ||
| body: | ||
| string: "{\n \"detail\": \"DAGRun with DAG ID: 'author_create_initialization_dag' | ||
| and DagRun ID: '00000000-0000-0000-0000-000000000001' not found\",\n \"status\": | ||
| 404,\n \"title\": \"Not Found\",\n \"type\": \"https://airflow.apache.org/docs/apache-airflow/2.8.3/stable-rest-api-ref.html#section/Errors/NotFound\"\n}\n" |
There was a problem hiding this comment.
there is 404 here, is this correct?
drjova
reviewed
Aug 20, 2024
Comment on lines
+129
to
+144
| headers: | ||
| Connection: | ||
| - close | ||
| Content-Length: | ||
| - '294' | ||
| Content-Type: | ||
| - application/problem+json | ||
| Date: | ||
| - Mon, 19 Aug 2024 13:16:38 GMT | ||
| Server: | ||
| - gunicorn | ||
| X-Robots-Tag: | ||
| - noindex, nofollow | ||
| status: | ||
| code: 404 | ||
| message: NOT FOUND |
There was a problem hiding this comment.
Yes. its due to the delete in the teardown trying to delete something that was already deleted during the test.
drjova
approved these changes
Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.