Refactoring categories #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikirenz
force-pushed
the
arxiv-inspire-ext-categ
branch
from
d45e9a9 to
c45d4f5
Compare
david-caro
reviewed
Dec 5, 2016
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
This generates something like:
arxiv_field_categories = [{'term': 'hep-ph'}, {'term': 'hep-th'}]
When what we need is just an array of strings:
arxiv_field_categories = ['hep-ph', 'hep-th']
There was a problem hiding this comment.
{
'items': {
'oneOf': [
{
'enum': ['one', 'two'],
'type': 'string'
}
]
},
'type': 'array',
'uniqueItems': True
}
4988dea to
c095f17
Compare
|
This looks great now 👍 , but we should wait for #41 to see if this is actually what it's needed before merging, though we can start modifying the rest of the code (inspire-next + hepcrawl) to adapt to this in the meantime, as if not like this, it will be quite similar I think. |
|
I forgot! this is a non-backwards compatible change, so you should use this: |
david-caro
suggested changes
Dec 5, 2016
rikirenz
force-pushed
the
arxiv-inspire-ext-categ
branch
2 times, most recently
from
a2d0081 to
e264d7f
Compare
rikirenz
force-pushed
the
arxiv-inspire-ext-categ
branch
2 times, most recently
from
1ea5678 to
4413868
Compare
* INCOMPATIBLE rename inspire_field_categories to inspire_categories. * Removed external_field_categories. * New values for inspire_field enum
rikirenz
force-pushed
the
arxiv-inspire-ext-categ
branch
from
4413868 to
04f2fc6
Compare
david-caro
approved these changes
Dec 8, 2016
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to create 2 fields: