-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed workspaces issues #1266
base: main
Are you sure you want to change the base?
Fixed workspaces issues #1266
Conversation
9b8db89
to
8a2fd7b
Compare
@@ -122,6 +122,7 @@ | |||
{ | |||
"name": "@elastic/elasticsearch", | |||
"policy": "45-days", | |||
"versions": ["7.9.0", "7.17.0", "8.15.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"versions": ">= 7"
"versions": ">= 7, 8.15.0"
testUtils.getVersions(versions, nameOfTheLib)
[latest7, latest8, latest9]
What is the currency bot doing?
- Major updates?
- Visibility: we want to know if a minor versions comes out and we are able to check the features
- Visibility: on what is tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"versions": ">= 7"
If we use this notation in the currencies.json, we need to initially generate the currencies.json the following:
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.15.0"]
...
In the test we use:
CURRENCY.testedVersions.forEach(...)
The currency bot in the night still runs a major and minor update check. If there is a new version, a PR is created for the currencies.json diff.
e.g. for major:
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.15.0", "9.0.0"]
...
e.g. for minor
{
"name": "@elastic/elasticsearch",
"supportedVersions": ">= 7"
"testedVersions": ["7.9.0", "8.16.0"]
...
This gives us visibility.
As soon as we merge the PR for the currencies.json, the testedVersions array is updated and the tests run against v9 or 8.16.0 or whatever.
"supportedVersions": ">= 7"
This can be publicly displayed and is the base how to generate the testedVersions array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, this is a great approach!
An alternative approach for https://jsw.ibm.com/browse/INSTA-7722 is to workaround the problems:
Possible ideas:
nohoist
([RRFC] Add nohoist option for workspaces npm/rfcs#287) -> problem: peer dependency requirements do not work such as "typeorm requires mssql v10, but we already test against v11 on root".npm
is loading the correct dependencyProblems we have to fix: