Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): Add basic support for EKS Pods on Fargate #472

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat(agent): Add basic support for EKS Pods on Fargate #472

merged 4 commits into from
Feb 12, 2024

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Nov 17, 2023

No description provided.

@Ferenc- Ferenc- force-pushed the eks-support branch 6 times, most recently from 9b4869c to 241b42d Compare November 17, 2023 19:17
@Ferenc- Ferenc- marked this pull request as draft November 17, 2023 20:17
@Ferenc- Ferenc- marked this pull request as ready for review November 17, 2023 20:39
basti1302
basti1302 reviewed Nov 20, 2023
View reviewed changes
instana/agent/aws_eks_fargate.py Outdated Show resolved Hide resolved
instana/collector/helpers/eks/pod.py Outdated Show resolved Hide resolved
instana/singletons.py Outdated Show resolved Hide resolved
instana/collector/aws_eks_fargate.py Outdated Show resolved Hide resolved
@Ferenc- Ferenc- force-pushed the eks-support branch 2 times, most recently from bcb3ae2 to 597688d Compare November 23, 2023 14:52
@Ferenc- Ferenc- force-pushed the eks-support branch 2 times, most recently from 55745a8 to 6a334b2 Compare January 17, 2024 14:21
@Ferenc- Ferenc- force-pushed the eks-support branch 2 times, most recently from 0bfa2d6 to caceee6 Compare February 12, 2024 00:09
pvital
pvital approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

My only suggestion is to change the c5666f3 commit message from test: Cover EKSFargateAgent to feat (test): Add EKSFargateAgent test cases since we are adding this whole set of test cases.

@Ferenc-
Copy link
Collaborator Author

Ferenc- commented Feb 12, 2024

feat (test): Add EKSFargateAgent test cases

Done

@Ferenc- Ferenc- requested a review from GSVarsha February 12, 2024 08:58
GSVarsha
GSVarsha approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

@Ferenc- Ferenc- merged commit a5ea693 into master Feb 12, 2024
12 checks passed
@Ferenc- Ferenc- deleted the eks-support branch February 12, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basti1302 basti1302 basti1302 left review comments

@pvital pvital pvital approved these changes

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ferenc- @basti1302 @pvital @GSVarsha