feat: Kafka FUP Phase I #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cagri Yonca <[email protected]>
Signed-off-by: Cagri Yonca <[email protected]>
GSVarsha
reviewed
Apr 14, 2025
| - methods: ["*"] # Applied to all methods | ||
| endpoints: ["span-topic", "topic4"] | ||
| # - methods: ["consume", "send"] | ||
| # endpoints: ["*"] # Applied to all topics |
There was a problem hiding this comment.
Please add a new line at EOF
GSVarsha
reviewed
Apr 14, 2025
| - methods: ["*"] # Applied to all methods | ||
| endpoints: ["span-topic", "topic4"] | ||
| # - methods: ["consume", "send"] | ||
| # endpoints: ["*"] # Applied to all topics |
There was a problem hiding this comment.
GSVarsha
reviewed
Apr 14, 2025
| @@ -52,6 +52,7 @@ dependencies = [ | |||
| "opentelemetry-api>=1.27.0", | |||
| "opentelemetry-semantic-conventions>=0.48b0", | |||
| "typing_extensions>=4.12.2", | |||
| "pyyaml>=6.0.2", | |||
There was a problem hiding this comment.
Why is pyyaml a dependency for the tracer?
There was a problem hiding this comment.
@GSVarsha, that's because we need to read YAML configuration files now. This is part of the design.
I don't like the idea of having it as one of the main dependencies of our package. Perhaps we can add it as an extra installation option. The users would then execute something like the following command if they want to use the Kafka filtering:
pip install instana[yaml]
GSVarsha
reviewed
Apr 14, 2025
|
|
||
|
|
||
| def get_operation_specifier(span_name: str) -> Optional[str]: | ||
| def get_operation_specifier(span_name: str) -> Tuple[str, str]: |
There was a problem hiding this comment.
Can you change this method's name since now it returns both operation_specifier_key and service_specifier_key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
configuration.yamlfile to filter specific services and methods now, as specified in the technical specification.configuration.yamlfile has the highest priority, usesendfor kafka-python andproducefor confluent-kafka: