Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The spec doesn't set upper limit for ec=1 if code>=500 #350

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: The spec doesn't set upper limit for ec=1 if code>=500 #350

merged 1 commit into from
Jan 3, 2024

Conversation

Ferenc-
Copy link
Contributor

@Ferenc- Ferenc- commented Jan 3, 2024

Quote from the spec:

For HTTP exit and entry spans alike, if a full request/response cycle has happened (which implies that an HTTP status code is present): If the HTTP status code is >= 500, the associated span MUST be marked as an error via span.ec.

This means that there is no upper limit, and this should apply to custom status codes as well, which might be above 511, or even 599.

@Ferenc- Ferenc- requested a review from pvital January 3, 2024 12:06
pvital
pvital approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@Ferenc- Ferenc- merged commit 96f2618 into master Jan 3, 2024
184 checks passed
@Ferenc- Ferenc- deleted the fix-error-codes branch January 3, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferenc- @pvital