Add new pipeline for currency report #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun Rajappa <[email protected]>
Signed-off-by: Arjun Rajappa <[email protected]>
pvital
requested changes
Nov 20, 2024
| - name: ruby_3_3_image_digest | ||
| type: string | ||
| description: Ruby 3.3 image digest | ||
| default: "sha256:5cf0004738f54bd67e4c4316394208ca38a6726eda7a1b0586d95601aad86e5d" |
There was a problem hiding this comment.
@arjun-rajappa, where is this image being pulled from? If possible, avoid Docker Hub.
There was a problem hiding this comment.
Its still from docker. There are a lot of changes that needs to be done for this. Will raise a separate PR just like one for python for registry change will that work?
There was a problem hiding this comment.
I think it will be good to make this change now. Then you have one less line to change in the future. 😄
Please also add a comment before the image line with the full URL of the image so we know which one is being used.
There was a problem hiding this comment.
Sure sure will do that!
|
Closing this as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new pipeline for currency report