Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rowanize the demos ... #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

dalehenrich
Copy link

GemTalk/Rowan#553 and GemTalk/Rowan#555. I've created this PR primarily to discuss what I've done to Rowanize this repo. Besides adding the rowan directory with the Rowan meta data, I've moved the the example packages around a bit and created some packages that include classes that can be loaded into GemStone ... GemStone base does (currently) support SharedPools (SharedPoools are supported in GLASS) ... I also suspect that I've broken the VAST package meta data ...

Anyway, this PR is against the master branch, but perhaps it should be shared on a rowan or gemstone branch until we work out all of the kinks ...

@dalehenrich
Copy link
Author

dalehenrich commented Dec 31, 2019

Hold off merging this PR until I merge my latest code into the vast branch of Rowan ... I'm renaming an instance variable in the component from conditionalPackages to conditionalProperties as part of GemTalk/Rowan#554 ... and my life will be a bit simpler if you hold off merging until I've converted these components and merged the code sans conditionalPackages into the vast branch ... I should have the conversion done by tomorrow afternoon ...

@dalehenrich
Copy link
Author

It took a little longer for me to finish up my work refactoring the component structure (componentNames and projectNames moved into conditional sections), but with this commit on the Rowan vast branch, I'm finished. I've also updated the rowan_553 branch (cb69685) with examples of the componetNames (emtpy lists) in the conditional structures) ... so you can merge at your leisier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant