Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dev-doc for process management #160

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Nov 19, 2024

ilab should be able to run detached processes, re-attach to them, and monitor them. This document introduces a first iteration of that process management

@cdoern cdoern force-pushed the ilab-processes branch 2 times, most recently from 329a0e2 to d62dad6 Compare November 20, 2024 16:02
@cdoern cdoern force-pushed the ilab-processes branch 5 times, most recently from 6c832c4 to fb61d35 Compare November 22, 2024 19:27
@cdoern cdoern force-pushed the ilab-processes branch 2 times, most recently from 4c5512e to d7a9a07 Compare November 27, 2024 04:02
@cdoern cdoern changed the title Introduce dev-doc for processes management Introduce dev-doc for process management Dec 16, 2024
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but otherwise LGTM

ilab should be able to run detached processes, re-attach to them, and monitor them

Signed-off-by: Charlie Doern <[email protected]>
@cdoern
Copy link
Contributor Author

cdoern commented Dec 18, 2024

This has been open for about a month now with two approvals. I am going to merge this as is, but I welcome and amendments in follow up PRs

@cdoern cdoern merged commit ad293d2 into instructlab:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants