-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dev-doc for process management #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
329a0e2
to
d62dad6
Compare
jaideepr97
reviewed
Nov 20, 2024
6c832c4
to
fb61d35
Compare
6 tasks
reidliu41
reviewed
Nov 26, 2024
reidliu41
reviewed
Nov 26, 2024
reidliu41
reviewed
Nov 26, 2024
4c5512e
to
d7a9a07
Compare
danmcp
reviewed
Dec 6, 2024
d7a9a07
to
3566472
Compare
jaideepr97
approved these changes
Dec 11, 2024
3566472
to
8bf3bf8
Compare
nathan-weinberg
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits but otherwise LGTM
ilab should be able to run detached processes, re-attach to them, and monitor them Signed-off-by: Charlie Doern <[email protected]>
8bf3bf8
to
4e1479c
Compare
This has been open for about a month now with two approvals. I am going to merge this as is, but I welcome and amendments in follow up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ilab should be able to run detached processes, re-attach to them, and monitor them. This document introduces a first iteration of that process management