-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Confluence documents as a knowledge source #64
Conversation
docs/confluence-doc-source.md
Outdated
- [ilab utilities module](https://github.com/instructlab/instructlab/blob/main/src/instructlab/utils.py) | ||
fetches documents | ||
- [unit test](https://github.com/instructlab/instructlab/tree/main/tests) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support the schema change, ilab, the taxonomy repo (possibly private) and the backend implementation (which does the proper SDG and training from the taxonomy repo) all must agree on the schema so they have a shared understanding of what a qna.yaml file looks like. So it requires coordination between ilab, the backend implementation and the taxonomy repo(s). So making a change in ilab alone is not sufficient.
So this design change will also require support/approval from the backend (SDG) team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makelinux could you please address @bjhargrave's comments so we can move forward? Thanks! |
d37ada8
to
3d955b6
Compare
Signed-off-by: Costa Shulyupin <[email protected]>
This pull request has been automatically marked as stale because it has not had activity within 30 days. It will be automatically closed if no further activity occurs within 7 days. |
This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it! |
Preview:
Confluence document source