Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart deployment #328

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kingaj12
Copy link

@kingaj12 kingaj12 commented May 2, 2024

No description provided.

@kingaj12 kingaj12 marked this pull request as draft May 2, 2024 20:16
@kingaj12 kingaj12 closed this May 2, 2024
@kingaj12 kingaj12 reopened this May 2, 2024
@russellb
Copy link
Member

russellb commented May 2, 2024

@dave-tucker I think you had some work-in-progress for running on Kubernetes as well, right?

@dave-tucker
Copy link
Collaborator

@russellb yep its already checked in. but using kustomize instead of helm

@russellb
Copy link
Member

russellb commented May 3, 2024

@kingaj12 have you taken a look at the kustomize work in the tree?

@kingaj12
Copy link
Author

kingaj12 commented May 3, 2024

Yes, the helm artifacts in this PR are initialized from the kustomize scripts. We have a lot more to add based on our experience deploying into Openshift cluster, which is why this is still a draft.

pull in new commits from instructlab/instructlab-bot
@vishnoianil
Copy link
Member

vishnoianil commented May 7, 2024

Yes, the helm artifacts in this PR are initialized from the kustomize scripts. We have a lot more to add based on our experience deploying into Openshift cluster, which is why this is still a draft.

@kingaj12 Thanks for the PR, looking forward to more updates on it. We are also planning to deploy the bot on OCP cluster. Here is the related issue -> #240

But our idea was to use the existing kustomize manifests that we use to deploy in kuberentes and adapt them for OCP, with the goal in mind to keep the dependency on tooling minimum.

We would love to hear about what more you are hacking in the context of github-bot. All the instructlab-bot contributors and maintainers hangout at InstructLab Slack #github-bot channel. We use this channel for brainstorming, discussion and hacking. Please feel free to join and ping us if you would like to discussion any of your in-progress contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants