ci: Upload phase 1 & phase 2 training logs for loss graphs #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimaredia
force-pushed
the
fix-loss-graphs-ci
branch
2 times, most recently
from
8214570
to
8352fba
Compare
Signed-off-by: Ali Maredia <[email protected]>
alimaredia
force-pushed
the
fix-loss-graphs-ci
branch
from
8352fba
to
f261630
Compare
RobotSail
reviewed
Nov 26, 2024
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" |
There was a problem hiding this comment.
It seems like this E2E file has an error - this line should be present after the output files are generated by running the python scripts/create-loss-graph.py
Suggested change
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" |
RobotSail
reviewed
Nov 26, 2024
| --pr-number "${{ github.event.pull_request.number }}" \ | ||
| --head-sha "${{ github.event.pull_request.head.sha }}" \ | ||
| --origin-repository "${{ github.repository }}" | ||
|
|
There was a problem hiding this comment.
You'll want to actually move the cat "${output_file}" >> "{GITHUB_STEP_SUMMARY}" step to take place in the upload to phase steps.
Otherwise the current logic is paradoxical - we never output the summary on a successful upload, but we try to upload it on error.
Suggested change
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" |
RobotSail
reviewed
Nov 26, 2024
| echo "::warning::Failed to upload loss graph to S3. This won't block the workflow, but you may want to investigate." | ||
| echo "Loss graph upload failed" >> "${GITHUB_STEP_SUMMARY}" | ||
|
|
||
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" |
There was a problem hiding this comment.
Move this one to the phase 1 upload step
Suggested change
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" |
RobotSail
reviewed
Nov 26, 2024
| @@ -295,10 +314,34 @@ jobs: | |||
| --head-sha "${{ github.event.pull_request.head.sha }}" \ | |||
| --origin-repository "${{ github.repository }}" | |||
|
|
|||
There was a problem hiding this comment.
You'll want to also echo the output file here:
Suggested change
| cat "${output_file}" >> "${GITHUB_STEP_SUMMARY}" | |
RobotSail
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.