Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for chat eval layout and auto-scroll #672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Collaborator

Fixes Job logs displayed above the chat bot input box in case of "Single Input Box" is selected.
Fixes Chat eval chat bot doesn't scroll down automatically
Fixes Chat Eval UI not showing the status

Description

Additionally fixes some other layout/css issues in the Chat eval.
Uses a status icon rather than a badge for the selected model to reduce horizontal space to allow side-by-side comparisons at lesser widths.

Screen shots

image

image

@jeff-phillips-18 jeff-phillips-18 force-pushed the chat-eval-fixes branch 2 times, most recently from d0ef7ef to cb016b5 Compare March 20, 2025 17:58
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
@Misjohns
Copy link
Collaborator

@jeff-phillips-18 @vishnoianil sorry I have a few questions here.

  • What does the green status icons represent? That the model is running?
  • What are the other status we could show here?
  • Why do we need to display a "good" icon. Adding a green check draws a users eye unnecessarily.
  • Could we display loading then only switch to an error icon if there's an issue with the model?
  • Can we not place the status icon inside the model dropdown menu? Look odd floating without any associated words.Here a PF component showing status toggle with helper text.
  • Is a icon enough to alert the user if a model isn't available? Maybe we should use something like an empty state that provides additional room for explanation and even how the user can resolve.

@jeff-phillips-18
Copy link
Collaborator Author

@jeff-phillips-18 @vishnoianil sorry I have a few questions here.

  • What does the green status icons represent? That the model is running?

Yes

  • What are the other status we could show here?

Error state for stopped or not running, spinner for loading/unloading

  • Why do we need to display a "good" icon. Adding a green check draws a users eye unnecessarily.

We currently show the state of the model server, if you think we only need error status or pending status we can do that

  • Could we display loading then only switch to an error icon if there's an issue with the model?

Yes

  • Can we not place the status icon inside the model dropdown menu? Look odd floating without any associated words.Here a PF component showing status toggle with helper text.

we could do that

  • Is a icon enough to alert the user if a model isn't available? Maybe we should use something like an empty state that provides additional room for explanation and even how the user can resolve.

The model server could be temporarily down. The user would no longer see their history if we showed an empty state instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants