Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button that links to blog #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rolfedh
Copy link

@rolfedh rolfedh commented Mar 1, 2025

Fixes #266

@rolfedh rolfedh force-pushed the add-blog-to-landing-page branch 5 times, most recently from 672af08 to 2b2cda9 Compare March 15, 2025 18:22
@rolfedh rolfedh force-pushed the add-blog-to-landing-page branch from 2b2cda9 to f3cd9de Compare March 15, 2025 18:31
@rolfedh
Copy link
Author

rolfedh commented Mar 15, 2025

First time committing here. Got my DCO signature sorted out.

@rolfedh rolfedh changed the title Add button that links to blog. Fixes #266 Add button that links to blog Mar 15, 2025
@rolfedh
Copy link
Author

rolfedh commented Mar 15, 2025

Hi @mscherer and @joesepi,

This is my first contribution to this repository. Could you please advise me on the process for getting PRs like this reviewed and merged? I appreciate your guidance.

Thank you!

@mscherer
Copy link
Contributor

Hi,

I would love to help, but I am not sure who is in charge of the more "editorial" decisions, I am taking care of making sure the website build, but anything above is not really my thing. From a quick look, the patch look correct, but as there was some focus on accessibility, I am not able to evaluate that part.

But I can let the CI run at minima. If no one answer here, I think you should get some attention from people on Slack.

@rolfedh
Copy link
Author

rolfedh commented Mar 18, 2025

Thanks, @mscherer.

I'll take care of the CI build error later today. It’s odd since I copied the code from similar blocks, but I’ll investigate and see what’s going on.

@mscherer
Copy link
Contributor

CI seems to just complain on the indentation, the link is not long enough to warrant a new line or something like that, see the previous link (the arxiv one) vs the documentation, (with href and classname on 1 line).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add blog to list of links on the website
2 participants