Skip to content

[MBL-18687][Student][Teacher] Assignment list consolidation #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

[MBL-18687][Student][Teacher] Assignment list consolidation #2903

wants to merge 58 commits into from
+4,974 −2,272

Conversation

domonkosadam
Copy link
Contributor

@domonkosadam domonkosadam commented Mar 21, 2025 •
edited
Loading

Test plan: Test Assignment list in Student and Teacher app. The database had been changed, so please test the migration from the previous version as well.

refs: MBL-18687
affects: Student, Teacher
release note: Assignment list modernisation.

Checklist

  • Follow-up e2e test ticket created or not needed
  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode
  • A11y checked
  • Approve from product

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

hermannakos
hermannakos approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@hermannakos hermannakos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but every test suite is failing, please address them before merging.

@kdeakinstructure kdeakinstructure self-requested a review April 15, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermannakos hermannakos hermannakos approved these changes

@kdeakinstructure kdeakinstructure Awaiting requested review from kdeakinstructure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domonkosadam @inst-danger @kdeakinstructure @hermannakos