[CLX-1158][Horizon] Learn Overview #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
|
Teacher Install Page |
|
Native Parent Install Page |
|
Student Install Page |
|
Teacher Install Page |
|
Native Parent Install Page |
|
Student Install Page |
|
Native Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
|
Native Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
tamaskozmer
requested changes
Apr 14, 2025
There was a problem hiding this comment.
- Pull to refresh animation is stuck.
- Paddings are inconsistent between the pages.
- Scrolling out the Webview is wierd, we shouldn't have padding at the top.
- I think we don't load the correct course (use my user and compare it with the web).
- The card shouldn't have any padding outside by the designs.
- Overview and My Progress tabs are switched compared to the design. (in the my progress design it's correct)
libs/horizon/src/main/java/com/instructure/horizon/features/home/HomeNavigation.kt
Outdated
Show resolved
Hide resolved
libs/horizon/src/main/java/com/instructure/horizon/features/learn/LearnScreen.kt
Outdated
Show resolved
Hide resolved
libs/horizon/src/main/java/com/instructure/horizon/features/learn/LearnScreen.kt
Show resolved
Hide resolved
|
Native Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
tamaskozmer
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.