Skip to content

Commit

Permalink
chore(ui-progress): improve accessibilty on documentation main page
Browse files Browse the repository at this point in the history
Closes: INSTUI-4263, INSTUI-4265, INSTUI-4272
  • Loading branch information
ToMESSKa committed Nov 26, 2024
1 parent 34fb8e0 commit e9b03b2
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 40 deletions.
9 changes: 2 additions & 7 deletions packages/__docs__/src/Header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,8 @@ class Header extends Component<HeaderProps> {
)

return (
<View
role="banner"
as="div"
margin="none none medium"
padding="none medium"
>
<Heading level="h2" as="h1">
<View as="div" margin="none none medium" padding="none medium">
<Heading level="h2" as="div">
<Link href="#index" isWithinText={false} display="block">
<View display="block" textAlign="center">
{corpLogo}
Expand Down
71 changes: 38 additions & 33 deletions packages/__docs__/src/Hero/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { Button, IconButton } from '@instructure/ui-buttons'
import { Flex } from '@instructure/ui-flex'
import { Img } from '@instructure/ui-img'
import { Link } from '@instructure/ui-link'
import { List } from '@instructure/ui-list'
import { InlineList, List } from '@instructure/ui-list'
import { Text } from '@instructure/ui-text'
import { View } from '@instructure/ui-view'
import {
Expand Down Expand Up @@ -290,7 +290,7 @@ class Hero extends Component<HeroProps> {
)

const sidebarContent = (
<View as="aside">
<View as="div">
<View as="div">
<Flex>
<Flex.Item>
Expand Down Expand Up @@ -453,37 +453,42 @@ class Hero extends Component<HeroProps> {
LMS.
</Text>
</View>

<View as="p" margin="0">
<Button
withBackground={false}
color="primary-inverse"
href="#usage"
margin="0 x-small x-small 0"
size={bigScreen ? 'large' : 'medium'}
>
Developer Quick Start
</Button>
<Button
withBackground={false}
color="primary-inverse"
renderIcon={IconGithubSolid as any}
href="https://github.com/instructure/instructure-ui"
size={bigScreen ? 'large' : 'medium'}
margin="0 x-small x-small 0"
>
Github
</Button>
<Button
focusColor="inverse"
color="success"
href="#v10-upgrade-guide"
size={bigScreen ? 'large' : 'medium'}
margin="0 x-small x-small 0"
>
10.0 Upgrade Guide
</Button>
</View>
<InlineList margin="0">
<InlineList.Item>
<Button
withBackground={false}
color="primary-inverse"
href="#usage"
margin="0 x-small x-small 0"
size={bigScreen ? 'large' : 'medium'}
>
Developer Quick Start
</Button>
</InlineList.Item>
<InlineList.Item>
<Button
withBackground={false}
color="primary-inverse"
renderIcon={IconGithubSolid as any}
href="https://github.com/instructure/instructure-ui"
size={bigScreen ? 'large' : 'medium'}
margin="0 x-small x-small 0"
>
Github
</Button>
</InlineList.Item>
<InlineList.Item>
<Button
focusColor="inverse"
color="success"
href="#v10-upgrade-guide"
size={bigScreen ? 'large' : 'medium'}
margin="0 x-small x-small 0"
>
10.0 Upgrade Guide
</Button>
</InlineList.Item>
</InlineList>
</View>
</ContentWrap>
</View>
Expand Down

0 comments on commit e9b03b2

Please sign in to comment.