Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui-date-time-input,ui-modal): migrate old Modal tests #1441

Merged
merged 1 commit into from
Feb 29, 2024
Merged

test(ui-date-time-input,ui-modal): migrate old Modal tests #1441

merged 1 commit into from
Feb 29, 2024

Conversation

git-nandor
Copy link
Contributor

Closes: INSTUI-3920

@git-nandor git-nandor self-assigned this Feb 13, 2024
@git-nandor git-nandor force-pushed the INSTUI-3920_convert_ui-modal_to_the_new_test_format branch 7 times, most recently from 90a0eb6 to c0b0694 Compare February 14, 2024 15:13
@github-actions GitHub Actions
Copy link

Preview URL: https://1441--preview-instui.netlify.app

@git-nandor git-nandor force-pushed the INSTUI-3920_convert_ui-modal_to_the_new_test_format branch 4 times, most recently from 95f3a1f to df7f23b Compare February 14, 2024 16:46
@git-nandor git-nandor force-pushed the INSTUI-3920_convert_ui-modal_to_the_new_test_format branch 3 times, most recently from 67ef511 to 0928096 Compare February 19, 2024 18:43
@git-nandor git-nandor force-pushed the INSTUI-3920_convert_ui-modal_to_the_new_test_format branch from 0928096 to 54d9c94 Compare February 19, 2024 18:45
balzss
balzss approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, works fine locally. left some comments about using cypress-real-events in the future but I'm fine leaving these ones as they are since they are working fine. great job!

cypress/component/Modal.cy.tsx Show resolved Hide resolved
cypress/component/Modal.cy.tsx Show resolved Hide resolved
@git-nandor git-nandor merged commit c6da05a into master Feb 29, 2024
8 checks passed
@git-nandor git-nandor deleted the INSTUI-3920_convert_ui-modal_to_the_new_test_format branch February 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@balzss balzss balzss approved these changes

Assignees

@git-nandor git-nandor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-nandor @balzss @joyenjoyer