Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-view): borderColor prop added to ContextView, borderColor now… #1763

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat(ui-view): borderColor prop added to ContextView, borderColor now… #1763

merged 1 commit into from
Nov 13, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Nov 7, 2024 •
edited
Loading

… can be a HEX code in View

Closes: INSTUI-4346

TEST PLAN:

  • check if ContextView accepts the borderColor prop e.g.: borderColor="alert", borderColor="#FF0000" (including the arrow)
  • check if View's borderColor prop accepts HEX code e.g.: borderColor="#FF0000" (including the arrow)
  • check the description of the borderColor in ContextView and View documentation

@ToMESSKa ToMESSKa self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-13 14:15 UTC

@ToMESSKa ToMESSKa force-pushed the INSTUI-4346_context_view_new_border_color_prop_and_view_hex_value_option branch from 201dd51 to 9467507 Compare November 7, 2024 10:53
@ToMESSKa ToMESSKa requested review from ke1k0, HerrTopi and balzss and removed request for ke1k0 November 7, 2024 11:08
@ToMESSKa ToMESSKa force-pushed the INSTUI-4346_context_view_new_border_color_prop_and_view_hex_value_option branch from 19052a8 to f8bdc32 Compare November 8, 2024 12:28
HerrTopi
HerrTopi approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@HerrTopi HerrTopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

balzss
balzss requested changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using the old tokens for borderColor (info, danger, etc.) the small arrow always have black borders

@balzss
Copy link
Contributor

balzss commented Nov 11, 2024

note: I've added a commit to remove the option from ContextView to support old color tokens (info, danger, etc.). You can still set them which would cause a mismatched border color but it is considered an invalid usecase.

@balzss balzss requested review from balzss and HerrTopi November 11, 2024 13:21
@balzss balzss force-pushed the INSTUI-4346_context_view_new_border_color_prop_and_view_hex_value_option branch from ba807ca to 1733fd5 Compare November 11, 2024 13:24
@ToMESSKa
feat(ui-view): add borderColor prop to ContextView; make borderColor …
9756093 
…accept HEX code as a string in View

Closes: INSTUI-4346
@ToMESSKa ToMESSKa force-pushed the INSTUI-4346_context_view_new_border_color_prop_and_view_hex_value_option branch from 1733fd5 to 9756093 Compare November 13, 2024 13:45
@ToMESSKa ToMESSKa merged commit a823d51 into master Nov 13, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4346_context_view_new_border_color_prop_and_view_hex_value_option branch November 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerrTopi HerrTopi HerrTopi approved these changes

@balzss balzss balzss approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToMESSKa @balzss @HerrTopi