Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes: tooltip close on esc; pagination indicator gap; pagination displayed as a html list for a11y #1770

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Nov 13, 2024

INSTUI-4347
INSTUI-4334
INSTUI-4353

test plan:

  • check if pagination indicators have an 8px gap now
  • inspect pagination indicators: should have a markup with <ul> and <li>
  • voiceover should announce that the indicators are in a list
  • tooltips should be dismissable with esc even when you hover on them (and any other way)

@balzss balzss self-assigned this Nov 13, 2024
@balzss balzss changed the title small fixe: tooltip close on esc; pagination indicator gap; pagination displayed as a html list for a11y small fixes: tooltip close on esc; pagination indicator gap; pagination displayed as a html list for a11y Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-22 18:55 UTC

@balzss balzss force-pushed the fix/pagination-tooltip-small-fixes branch from a08a82b to 79611ad Compare November 14, 2024 14:28
@balzss balzss force-pushed the fix/pagination-tooltip-small-fixes branch from 79611ad to a1828cc Compare November 14, 2024 15:55
@balzss balzss force-pushed the fix/pagination-tooltip-small-fixes branch from a1828cc to ece9786 Compare November 22, 2024 12:16
@balzss balzss force-pushed the fix/pagination-tooltip-small-fixes branch from ece9786 to 7462d0b Compare November 22, 2024 12:48
@balzss balzss merged commit e6e5a7b into master Nov 22, 2024
11 checks passed
@balzss balzss deleted the fix/pagination-tooltip-small-fixes branch November 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants