Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ui-dialog): add a11y clarifications to Dialog docs #1785

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Nov 21, 2024

Closes: INSTUI-4293, INSTUI-4291

ISSUES:

  • the form labels in the dialog example are not descriptive enough
  • the Dialog example does not have a role or appropriate description

TEST PLAN:

  • when opening the Dialog example, the screen reader should announce that it is a dialog and read the dialog's label (e.g., "Full name form").
  • input labels should be descriptive in the example, such as "First name" instead of just "First", when using a screenreader
  • review the added recommendations for dialog accessibility

@ToMESSKa ToMESSKa self-assigned this Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-22 13:21 UTC

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

@ToMESSKa ToMESSKa merged commit 0c00612 into master Nov 22, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4293_dialog_example_not_descriptive branch November 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants