Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-breadcrumb): add and update aria tags in Breadcrumb #1788

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Nov 22, 2024

Closes: INSTUI-4268

ISSUES:

  • if the current page is represented as a link in the breadcrumb, it should have an aria-current attribute (https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/) - now breadcrumb doesn't have such attribute
  • the examples in the breadcrumb do not have descriptive aria-labels

TEST PLAN:

  • add the href="#" prop to the current element (College of Life Sciences) in the first example in Breadcrumb
  • the current element should now have an aria-current attribute in HTML
  • the examples in the breadcrumb should have descriptive aria-labels ("breadcrumb" instead of "you are here")

@ToMESSKa ToMESSKa self-assigned this Nov 22, 2024
Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1788/
on branch gh-pages at 2024-11-22 13:14 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant