-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header support #29
base: master
Are you sure you want to change the base?
Conversation
0532799
to
ba9815c
Compare
Add support for adding extra headers with '-H' or '--header'. The flag can be specified multiple times to add multiple headers
ba9815c
to
e550de3
Compare
@garethr can you please check what else is needed to merge this? |
@brendanjryan , @jburianek , @Sharpie , @evrardjp , @garethr can you please help to figure out what else is needed to merge this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a maintainer in this, and I haven't tested it, but the code looks good. I would clarify how a user could write the header options, so that they don't have to read the code for it. That could be done by giving an example of the Content-Type and Accept in the readme by showing you're passing those in the command line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My contribution to this project amounts to a one-line change and it's been a fair spell since I've done a lot of Python...
...but this looks reasonable to me. Looks like it implements curl
semantics for the -H
flag 👍
Thanks, I took your names from the head bubles from the right side bar in GitHub. Maybe pinging @garethr is more effective. |
Looks okay at first sight. Yeah I am not a maintainer either. |
Add support for adding extra headers with '-H' or '--header'.
The flag can be specified multiple times to add multiple headers