Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty collection and revision fields as empty str #172

Merged
merged 1 commit into from
Jan 8, 2025
Merged

empty collection and revision fields as empty str #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions one/tests/test_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def test_register_files(self):
r, = self.client.register_files(file_list=[file])
self.assertEqual(r['revision'], rev['name'])
self.assertTrue(r['default'])
self.assertIsNone(r['collection'])
self.assertEqual('', r['collection'])

# Register exact dataset revision again - it should append an 'a'
# When we re-register the original it should move them into revision with today's date
Expand All @@ -337,7 +337,7 @@ def test_register_files(self):
file = files[1].parent.joinpath(f'#{r2["revision"]}#', file.name)
self.assertTrue(file.exists())

self.assertIsNone(r3['revision'])
self.assertEqual('', r3['revision'])
self.assertTrue(files[2].exists())

# Protect the latest datasets
Expand Down
Loading