Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logging and release notes #662

Merged
merged 1 commit into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ibllib/io/extractors/camera.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,13 @@ def _extract(self, sync=None, chmap=None, video_path=None, sync_label='audio',
motion_class = vmotion.MotionAlignmentFullSession(self.session_path, self.label, sync='nidq', upload=True)
new_times = motion_class.process()
if not motion_class.qc_outcome:
raise ValueError(f'Wheel alignment failed to pass qc: {motion_class.qc}')
raise ValueError(f'Wheel alignment for {self.label} camera failed to pass qc: {motion_class.qc}')
else:
_logger.warning(f'Wheel alignment successful, qc: {motion_class.qc}')
_logger.warning(f'Wheel alignment for {self.label} camera successful, qc: {motion_class.qc}')
return new_times

except Exception as err:
_logger.critical(f'Failed to align with wheel: {err}')
_logger.critical(f'Failed to align with wheel for {self.label} camera: {err}')

if length < raw_ts.size:
df = raw_ts.size - length
Expand Down
4 changes: 4 additions & 0 deletions release_notes.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Develop
- Add full video wheel motion alignment code to ibllib.io.extractors.video_motion module
- Change FPGA camera extractor to attempt wheel alignment if audio alignment fails

## Release Notes 2.26

### features
Expand Down
Loading