Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visual design and compatibility for SonarQube 10.8 / Community Build 24.12 #78

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

fourls
Copy link
Collaborator

@fourls fourls commented Dec 17, 2024

This PR updates DelphiLint for SonarQube 10.8 / Community Build 24.12 support, including a few relatively major changes:

  • Client-side resources (e.g. images) are now automatically collected and built, rather than manually added to each project
  • Rule descriptions no longer use the monolithic htmlDesc field, which is removed in 10.8 / 24.12 - they are now split into description sections, which are displayed in a tabbed view
  • The taxonomy mode (MQR vs. Standard Experience) in 10.8 / 24.12 is now supported
  • Visual styling has been updated to match SonarQube 10.8

Some images:

image

image

image

image

@fourls fourls requested a review from Cirras December 17, 2024 05:27
@fourls fourls force-pushed the community-build-compat branch from 621bbce to cacfb58 Compare December 17, 2024 05:32
@fourls
Copy link
Collaborator Author

fourls commented Dec 17, 2024

The format check failure is due to an issue with the upstream action - #79 fixes the problem.

@fourls fourls force-pushed the community-build-compat branch from cacfb58 to 9f83dfd Compare December 17, 2024 22:31
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A couple of minor questions, and I'm yet to actually test - but code changes are looking good overall.

@fourls fourls force-pushed the community-build-compat branch 2 times, most recently from db3c3ed to bf4e013 Compare December 23, 2024 01:42
@fourls fourls requested a review from Cirras December 23, 2024 01:43
@fourls fourls force-pushed the community-build-compat branch from bf4e013 to 1633897 Compare December 23, 2024 02:30
@fourls
Copy link
Collaborator Author

fourls commented Dec 23, 2024

Rebased on top of #81

Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this bug in testing.
image

Also, what are our feelings about the appearance of the new tabs in light mode?
I'm so-so on the darkened-background with thick black line at the bottom.
image

@fourls
Copy link
Collaborator Author

fourls commented Jan 16, 2025

Fixed the bug and updated the styling of the tabs:

image

image

The selected tab is clBtnFace and the hovered tab is clBtnShadow.

@fourls fourls force-pushed the community-build-compat branch from 1633897 to e25ae1d Compare January 16, 2025 06:38
@fourls fourls requested a review from Cirras January 16, 2025 06:38
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks much better - I have some thoughts on further tweaks.

  • Should we could remove the top line from the tab bar?
  • Was there a reason we couldn't use the same blue highlights from the issue list?

Here's a mockup of the top line being removed
image

Same as before, but the blue highlights being used instead:
image

Here's a mockup where we've gone back to using a fat line at the bottom for our "selected" indicator:
image

@fourls fourls force-pushed the community-build-compat branch from e25ae1d to 009acfe Compare January 17, 2025 00:19
@fourls
Copy link
Collaborator Author

fourls commented Jan 17, 2025

Top line removed.

Was there a reason we couldn't use the same blue highlights from the issue list?

It's not clear which (if any) system colour is being used for these highlights. As a concession I've changed the button colours to be a little brighter (not that I can see much difference):

image
image

@fourls fourls requested a review from Cirras January 17, 2025 00:23
Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@fourls fourls merged commit 05be356 into master Jan 17, 2025
7 checks passed
@fourls fourls deleted the community-build-compat branch January 17, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants