-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update visual design and compatibility for SonarQube 10.8 / Community Build 24.12 #78
Conversation
621bbce
to
cacfb58
Compare
The format check failure is due to an issue with the upstream action - #79 fixes the problem. |
cacfb58
to
9f83dfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A couple of minor questions, and I'm yet to actually test - but code changes are looking good overall.
server/delphilint-server/src/main/java/au/com/integradev/delphilint/remote/ImpactSeverity.java
Outdated
Show resolved
Hide resolved
...hilint-server/src/main/java/au/com/integradev/delphilint/remote/sonarqube/SonarQubeHost.java
Outdated
Show resolved
Hide resolved
db3c3ed
to
bf4e013
Compare
bf4e013
to
1633897
Compare
Rebased on top of #81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1633897
to
e25ae1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks much better - I have some thoughts on further tweaks.
- Should we could remove the top line from the tab bar?
- Was there a reason we couldn't use the same blue highlights from the issue list?
Here's a mockup of the top line being removed
Same as before, but the blue highlights being used instead:
Here's a mockup where we've gone back to using a fat line at the bottom for our "selected" indicator:
e25ae1d
to
009acfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
This PR updates DelphiLint for SonarQube 10.8 / Community Build 24.12 support, including a few relatively major changes:
htmlDesc
field, which is removed in 10.8 / 24.12 - they are now split into description sections, which are displayed in a tabbed viewSome images: