fixes #220: Add warning for redundant "inlined" statements

integrity-tf · Jan 25, 2019 · a74388a · a74388a
1 parent cdd98ef
commit a74388a
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/de.gebit.integrity.dsl/src/de/gebit/integrity/validation/DSLJavaValidator.java b/de.gebit.integrity.dsl/src/de/gebit/integrity/validation/DSLJavaValidator.java
@@ -51,6 +51,7 @@
 import de.gebit.integrity.dsl.Parameter;
 import de.gebit.integrity.dsl.ParameterTableHeader;
 import de.gebit.integrity.dsl.ParameterTableValue;
+import de.gebit.integrity.dsl.Suite;
 import de.gebit.integrity.dsl.SuiteDefinition;
 import de.gebit.integrity.dsl.SuiteParameterDefinition;
 import de.gebit.integrity.dsl.SuiteReturnDefinition;
@@ -340,6 +341,19 @@ public void checkForPrivateConstantInSuite(ConstantDefinition anEntity) {
 		}
 	}
 
+	/**
+	 * Checks for redundant suite inline statements.
+	 * 
+	 * @param aSuiteStatement
+	 */
+	@Check
+	public void checkSuiteStatement(Suite aSuiteStatement) {
+		if (aSuiteStatement.getInlined() != null && aSuiteStatement.getDefinition().getInlined() != null) {
+			warning("Redundant inline statement: the invoked suite is already defined as 'inlined'",
+					DslPackage.Literals.SUITE__INLINED);
+		}
+	}
+
 	/**
 	 * Checks for missing parameters.
 	 *