moved initialization method into TestRunner interface

integrity-tf · Sep 27, 2013 · dfd68a3 · dfd68a3
1 parent 1e38869
commit dfd68a3
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 24 deletions.
diff --git a/de.gebit.integrity.runner/src/de/gebit/integrity/runner/DefaultTestRunner.java b/de.gebit.integrity.runner/src/de/gebit/integrity/runner/DefaultTestRunner.java
@@ -358,28 +358,7 @@ protected int getChildProcessKillTimeout() {
 	 */
 	protected Map<ForkDefinition, Set<SuiteDefinition>> setupSuitesExecuted = new HashMap<ForkDefinition, Set<SuiteDefinition>>();
 
-	/**
-	 * Initializes a fresh test runner instance.
-	 * 
-	 * @param aModel
-	 *            the model to execute
-	 * @param someParameterizedConstants
-	 *            Maps fully qualified constant names (must be those with the "parameterized" keyword) to their desired
-	 *            value. This way, test execution can be parameterized from outside.
-	 * @param aCallback
-	 *            the callback to use to report test results
-	 * @param aRemotingPort
-	 *            the port on which the remoting server should listen, or null if remoting should be disabled
-	 * @param aRemotingBindHost
-	 *            the host name (or IP) to which the remoting server should bind
-	 * @param aRandomSeed
-	 *            the seed for the {@link RandomNumberOperation} (optional; randomly determined if not given).
-	 * @param someCommandLineArguments
-	 *            all command line arguments as given to the original Java programs' main routine (required for
-	 *            forking!)
-	 * @throws IOException
-	 *             if the remoting server startup fails
-	 */
+	@Override
 	public void initialize(TestModel aModel, Map<String, String> someParameterizedConstants,
 			TestRunnerCallback aCallback, Integer aRemotingPort, String aRemotingBindHost, Long aRandomSeed,
 			String[] someCommandLineArguments) throws IOException {

diff --git a/de.gebit.integrity.runner/src/de/gebit/integrity/runner/TestModel.java b/de.gebit.integrity.runner/src/de/gebit/integrity/runner/TestModel.java
@@ -476,8 +476,8 @@ public TestRunner initializeTestRunner(TestRunnerCallback aCallback,
 			Long aRandomSeed, String[] someCommandLineArguments) throws IOException {
 		TestRunner tempRunner = injector.getInstance(TestRunner.class);
 
-		((DefaultTestRunner) tempRunner).initialize(this, someParameterizedConstants, aCallback, aRemotingPort,
-				aRemotingBindHost, aRandomSeed, someCommandLineArguments);
+		tempRunner.initialize(this, someParameterizedConstants, aCallback, aRemotingPort, aRemotingBindHost,
+				aRandomSeed, someCommandLineArguments);
 
 		return tempRunner;
 	}

diff --git a/de.gebit.integrity.runner/src/de/gebit/integrity/runner/TestRunner.java b/de.gebit.integrity.runner/src/de/gebit/integrity/runner/TestRunner.java
@@ -7,8 +7,12 @@
  *******************************************************************************/
 package de.gebit.integrity.runner;
 
+import java.io.IOException;
+import java.util.Map;
+
 import de.gebit.integrity.dsl.SuiteDefinition;
 import de.gebit.integrity.dsl.VariantDefinition;
+import de.gebit.integrity.runner.callbacks.TestRunnerCallback;
 import de.gebit.integrity.runner.results.SuiteSummaryResult;
 
 /**
@@ -19,6 +23,33 @@
  */
 public interface TestRunner {
 
+	/**
+	 * Initializes a fresh test runner instance.
+	 * 
+	 * @param aModel
+	 *            the model to execute
+	 * @param someParameterizedConstants
+	 *            Maps fully qualified constant names (must be those with the "parameterized" keyword) to their desired
+	 *            value. This way, test execution can be parameterized from outside.
+	 * @param aCallback
+	 *            the callback to use to report test results
+	 * @param aRemotingPort
+	 *            the port on which the remoting server should listen, or null if remoting should be disabled
+	 * @param aRemotingBindHost
+	 *            the host name (or IP) to which the remoting server should bind
+	 * @param aRandomSeed
+	 *            the seed for the {@link de.gebit.integrity.runner.operations.RandomNumberOperation} (optional;
+	 *            randomly determined if not given).
+	 * @param someCommandLineArguments
+	 *            all command line arguments as given to the original Java programs' main routine (required for
+	 *            forking!)
+	 * @throws IOException
+	 *             if the remoting server startup fails
+	 */
+	void initialize(TestModel aModel, Map<String, String> someParameterizedConstants, TestRunnerCallback aCallback,
+			Integer aRemotingPort, String aRemotingBindHost, Long aRandomSeed, String[] someCommandLineArguments)
+			throws IOException;
+
 	/**
 	 * Executes a specified suite. Designated starting point for test execution.
 	 *