Emulator.dsc: Change BaseStackCheckLib to StackCheckLibNull #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since EDKII PR: tianocore/edk2#5957 has been removed the BaseStackCheckLib, and the new StackCheckLib dependency library StackCheckFailureHookLib has not yet been made public, so we can only use StackCheckLibNull. Signed-off-by: Chao Li <[email protected]>
|
@andreiw Hi Andrei, this repo will not build if we update the edk2 code base to a9b38305b64ef5997d0ba5f7d2797a75edd1f9ef or newer, I have fixed it, PLS check, THX! :) |
|
@ardbiesheuvel Hi Ard, could you please review this change? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EDKII PR: tianocore/edk2#5957 has been removed the BaseStackCheckLib, and the new StackCheckLib dependency library StackCheckFailureHookLib has not yet been made public, so we can only use StackCheckLibNull.