fix exporting buffers with 3 planes and VA_EXPORT_SURFACE_SEPARATE_LAYERS #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YERS To get the plane offset, y_cb_offset or y_cr_offset must be multiplied with the pitch for the 'Y' plane. See for example i965_DeriveImage(). Without this, exporting formats with 3 planes where cb_cr_pitch == width/2 is broken, because the offset of the third plane is calculated incorrectly.
|
Just wanted to drop that I've been hitting this as well. I've worked around it with a dirty Gstreamer patch which usually gives the right results, but not always. Would be nice to still see this land! |
|
P.S.: I verified that this MR fixes playback with Gstreamer 1.24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the plane offset, y_cb_offset or y_cr_offset must be multiplied with
the pitch for the 'Y' plane. See for example i965_DeriveImage().
Without this, exporting formats with 3 planes where cb_cr_pitch == width/2
is broken, because the offset of the third plane is calculated incorrectly.